Open
Conversation
mabeett
force-pushed
the
1148_secrets_handling
branch
6 times, most recently
from
8fcc43b to
1f46ed0
Compare
mabeett
force-pushed
the
1148_secrets_handling
branch
from
1f46ed0 to
3ada56d
Compare
J0WI
reviewed
Sep 18, 2024
| echo "note: using ${var} variable for ${var} value" | ||
| export "$var"="${varValue}" | ||
| elif [ -n "${def}" ]; then | ||
| echo "note: using invoked definition for ${var} value" |
Contributor
Author
There was a problem hiding this comment.
I was just following the criteria in the context, take note the variable name is printed not the value.
Contributor
|
If you export all secret values as env, they would also shou up in the containers definition etc. again in cleartext. |
Contributor
Author
What do you mean? the variable is exported in the entrypoint. In see. this snippet with a debian image contianer: $ docker run --name test --rm -it debian
root@9cd023377043:/# export CHECK=gotcha
root@9cd023377043:/# env | grep got
CHECK=gotcha
root@9cd023377043:/#in another shell $ docker inspect test | jq . | grep gotc
$ echo $?
1
$ docker inspect test | jq '.[0].Config.Env[] ' -r
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
$ |
Secrets files handled only in the entrypoint, converted during initial execuition. Solves nextcloud#1148 Signed-off-by: Matías Pecchia <179218+mabeett@users.noreply.github.com>
Signed-off-by: Matías Pecchia <179218+mabeett@users.noreply.github.com>
mabeett
force-pushed
the
1148_secrets_handling
branch
from
3ada56d to
1a0fb1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secrets files handled only in the entrypoint, converted during initial execuition.
Fixes #1148